Skip to content

Bump C# emitter dependencies to TypeSpec 1.9.0#9675

Merged
JoshLove-msft merged 12 commits intomainfrom
copilot/bump-csharp-emitter-dependencies
Feb 14, 2026
Merged

Bump C# emitter dependencies to TypeSpec 1.9.0#9675
JoshLove-msft merged 12 commits intomainfrom
copilot/bump-csharp-emitter-dependencies

Conversation

Copy link
Contributor

Copilot AI commented Feb 10, 2026 •
edited
Loading

Plan: Bump C# emitter dependencies to TypeSpec 1.9.0

  • Update package.json dependencies to latest versions
    • Update @typespec/compiler from 1.8.0 to 1.9.0
    • Update @typespec/http from 1.8.0 to 1.9.0
    • Update @typespec/openapi from 1.8.0 to 1.9.0
    • Update @typespec/rest from 0.78.0 to 0.79.0
    • Update @typespec/streams from 0.78.0 to 0.79.0
    • Update @typespec/versioning from 0.78.0 to 0.79.0
    • Update @azure-tools/typespec-client-generator-core from 0.64.4 to 0.65.1
    • Add @typespec/sse 0.79.0 (new peer dependency)
    • Update @typespec/json-schema from 1.8.0 to 1.9.0
    • Update @typespec/library-linter from 0.78.0 to 0.79.0
    • Update @typespec/xml from 0.78.0 to 0.79.0
    • Update @azure-tools/azure-http-specs from 0.1.0-alpha.35 to 0.1.0-alpha.37
    • Update @typespec/http-specs from 0.1.0-alpha.30 to 0.1.0-alpha.32
    • Update @typespec/spector from 0.1.0-alpha.20 to 0.1.0-alpha.23
    • Add @azure-tools/typespec-azure-core 0.65.0
    • Update peerDependencies to match devDependencies versions
  • Fix TypeScript compilation errors due to type changes in TCGC
    • Update InputDateTimeType encode property to accept DateTimeKnownEncoding | string
    • Update InputDurationType encode property to accept DurationKnownEncoding | string
  • Convert C# encoding types to extensible string enums
    • Convert DateTimeKnownEncoding from enum to extensible string enum (readonly struct pattern)
    • Convert DurationKnownEncoding from enum to extensible string enum (readonly struct pattern)
    • Maintain known encoding values as static properties (Rfc3339, Rfc7231, UnixTimestamp for DateTime; Iso8601, Seconds, Constant, Milliseconds for Duration)
    • Add implicit string conversion to support custom encoding formats
    • Update JSON converters to accept any string value instead of only known enums
    • Update TypeFactory switch expressions to handle custom encodings with SerializationFormat.Default
    • Use InvariantCultureIgnoreCase for string comparison (matching generated extensible enum pattern)
    • Use StringComparer.InvariantCultureIgnoreCase for GetHashCode
    • Add EditorBrowsable attributes to Equals and GetHashCode
    • Update tests to work with extensible enum pattern
  • Fix C# generator runtime error for enum array encoding
    • Update MrwSerializationTypeDefinition to use PropertyInitializationType instead of FrameworkType for custom enum types
  • Run npm install to update package-lock.json
  • Run npm run build to ensure build succeeds
  • Run npm test to ensure all tests pass (183 emitter tests, 80 Input tests, 1101 ClientModel tests, 15 Spector tests passed)
  • Regenerate all test libraries using eng/scripts/Generate.ps1
    • All existing specs regenerated successfully
    • Generated code compiles without errors
  • Merge latest changes from main branch
    • Resolved merge conflict in tspCodeModel.json
    • Verified build succeeds after merge
    • Verified tests pass after merge
  • Verify all changes are working correctly
Original prompt

This section details on the original issue you should resolve

<issue_title>Bump C# emitter dependencies</issue_title>
<issue_description>We should bump to the new typespec/compiler version 1.9.0 and all the other new versions for typespec packages.</issue_description>

Comments on the Issue (you are @copilot in this section)

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@JoshLove-msft
Bump C# emitter dependencies to TypeSpec 1.9.0
d12ddc8 
Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>
@microsoft-github-policy-service microsoft-github-policy-service bot added the emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp label Feb 10, 2026
@JoshLove-msft
Fix enum array encoding issue for TypeSpec 1.9.0 compatibility
7d75552 
Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>
Copilot AI changed the title [WIP] Bump C# emitter dependencies to version 1.9.0 Bump C# emitter dependencies to TypeSpec 1.9.0 Feb 10, 2026
Copilot AI requested a review from JoshLove-msft February 10, 2026 23:45
@JoshLove-msft
Copy link
Contributor

JoshLove-msft commented Feb 11, 2026

@copilot sync from main

Copy link
Contributor Author

Copilot AI commented Feb 11, 2026

@JoshLove-msft Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 156f1fbe-a7f3-4258-ab39-3a0992a18b7d

Sorry for the inconvenience!

jorgerangel-msft
jorgerangel-msft reviewed Feb 12, 2026
View reviewed changes
@jorgerangel-msft
Bump TCGC to 0.65.1 and regenerate test projects
ac66f06 
Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
@jorgerangel-msft
Copy link
Contributor

jorgerangel-msft commented Feb 12, 2026

@copilot pull the latest from main and address any merge conflicts

Merge branch 'main' into copilot/bump-csharp-emitter-dependencies
b9915cb 
# Conflicts:
#	packages/http-client-csharp/generator/TestProjects/Local/Sample-TypeSpec/tspCodeModel.json
Copy link
Contributor Author

Copilot AI commented Feb 12, 2026

@copilot pull the latest from main and address any merge conflicts

Done in commit b9915cb. Merged main branch (20 commits) into the PR branch. Resolved merge conflict in tspCodeModel.json. Build succeeds and all tests pass (183 emitter tests, 23 test files).

@jorgerangel-msft
Convert DateTimeKnownEncoding and DurationKnownEncoding to extensible…
db0d1e3 
… string enums

Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
@jorgerangel-msft
Copy link
Contributor

jorgerangel-msft commented Feb 12, 2026

@copilot there are some CI failures. We should regenerate all the test libraries using the ./eng/Generate.ps1 script

@jorgerangel-msft
Use InvariantCultureIgnoreCase for extensible enum comparison
65ab7a5 
Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
@jorgerangel-msft
Copy link
Contributor

jorgerangel-msft commented Feb 13, 2026

@copilot there are still test failures in CI. Investigate and fix

Copy link
Contributor Author

Copilot AI commented Feb 13, 2026

@copilot there are still test failures in CI. Investigate and fix

I checked the CI workflows and they show "action_required" status, which typically means they're waiting for approval to run rather than having test failures. The latest commit (65ab7a5) has workflows pending approval.

All local tests pass successfully:

  • 183 emitter tests passed
  • 80 Input tests passed
  • 1101 ClientModel tests passed
  • 15 Spector tests passed (823 skipped)
  • 0 failures

Could you please approve the CI workflows to run, or if you're seeing specific test failures, let me know which tests are failing so I can investigate and fix them?

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 14, 2026

Open in StackBlitz

npm i https://pkg.pr.new/microsoft/typespec/@typespec/http@9675

npm i https://pkg.pr.new/microsoft/typespec/@typespec/http-client@9675

npm i https://pkg.pr.new/microsoft/typespec/@typespec/http-client-csharp@9675

commit: dfa05eb

@github-actions
Copy link
Contributor

github-actions bot commented Feb 14, 2026

No changes needing a change description found.

@JoshLove-msft JoshLove-msft marked this pull request as ready for review February 14, 2026 03:20
@JoshLove-msft JoshLove-msft added this pull request to the merge queue Feb 14, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 14, 2026
@JoshLove-msft JoshLove-msft added this pull request to the merge queue Feb 14, 2026
Merged via the queue into main with commit 071cc29 Feb 14, 2026
23 checks passed
@JoshLove-msft JoshLove-msft deleted the copilot/bump-csharp-emitter-dependencies branch February 14, 2026 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsquire jsquire jsquire approved these changes

@jorgerangel-msft jorgerangel-msft Awaiting requested review from jorgerangel-msft jorgerangel-msft is a code owner

@m-nash m-nash Awaiting requested review from m-nash m-nash is a code owner

@christothes christothes Awaiting requested review from christothes christothes is a code owner

@ShivangiReja ShivangiReja Awaiting requested review from ShivangiReja ShivangiReja is a code owner

@joseharriaga joseharriaga Awaiting requested review from joseharriaga joseharriaga is a code owner

+1 more reviewer

@JoshLove-msft JoshLove-msft JoshLove-msft approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JoshLove-msft JoshLove-msft

Copilot code review Copilot

Labels

emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bump C# emitter dependencies

4 participants

@JoshLove-msft @jorgerangel-msft @jsquire